Iris units now hard coded to prevent error#187
Iris units now hard coded to prevent error#187trexfeathers merged 5 commits intoscitools-classroom:masterfrom
Conversation
…to show coastline grid over top of coloured mesh.
|
SciTools/iris#3795 is what changed the behaviour. There's a lot more detail in items linked from there. |
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Without running through the whole course myself, I will have to take your word for it that you've covered all cases! What you have changed makes sense.
I think it would be sensible to include a minor comment for the course participant, explaining that both the name and the units of the new coordinate must match those of the existing coordinates. It'd probably be too confusing to include any explanation about why the units are '1'.
…apter 4, where it's taught
|
Have now done, added the following sentence into Chapter 4, where filling coordinates for merging is taught: |
2 participants
Closes #185.
Corrected code in Iris tutorial Chapters 4 and 7. Units have now been hardcoded, which stops the demonstrative code throwing an error.
Should really include some explanation as to why the units need to be hard coded, but I'm not up to date enough as to write it myself; perhaps something to be added later.